Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: improve validate mesg sec/op delta by -72% #59

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

muktihari
Copy link
Owner

  • remove the need to allocate new slices improve the performance by an order of magnitude.
goos: darwin
goarch: amd64
pkg: github.com/muktihari/fit/encoder
cpu: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
           │   old.txt    │               new.txt               │
           │    sec/op    │   sec/op     vs base                │
Validate-4   147.70n ± 3%   40.28n ± 0%  -72.73% (p=0.000 n=10)

           │  old.txt   │              new.txt               │
           │    B/op    │   B/op     vs base                 │
Validate-4   64.00 ± 0%   0.00 ± 0%  -100.00% (p=0.000 n=10)

           │  old.txt   │               new.txt               │
           │ allocs/op  │ allocs/op   vs base                 │
Validate-4   1.000 ± 0%   0.000 ± 0%  -100.00% (p=0.000 n=10)

@muktihari muktihari added the performance Changes related to performance improvement label Dec 21, 2023
@muktihari muktihari self-assigned this Dec 21, 2023
@muktihari muktihari merged commit cdf8183 into master Dec 21, 2023
1 check passed
@muktihari muktihari deleted the perf/encoder-validator branch December 21, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Changes related to performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant