fix: decoder on component expansion #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now component expansion will expand the expanded component (the destination field) that can itself requiring expansion.
The expanded component candidate's value now will be matched with the scale offset with the destination field.
Accumulate and bits calculation is in uint32 since Profile.xlsx (on Bits's comment) says:
Field's
SubFieldSubtitution
method now returning single value (*subField) instead of two (*subField, bool), since it will be nil anyway if no SubField is found.Fix on
SubFieldSubtitution
should have continue to lookup instead of returning when 1 single map is not match.Now when creating fields slice, we use
fieldsArray [256]proto.Field
as backing array for temporary slicing, this way we don't need to worry about component expansion re-triggeringruntime.mallocgc
causing performance overhead.