Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoder on component expansion #66

Merged
merged 1 commit into from
Dec 26, 2023

Conversation

muktihari
Copy link
Owner

@muktihari muktihari commented Dec 26, 2023

  • Now component expansion will expand the expanded component (the destination field) that can itself requiring expansion.

  • The expanded component candidate's value now will be matched with the scale offset with the destination field.

  • Accumulate and bits calculation is in uint32 since Profile.xlsx (on Bits's comment) says:

    "Current implementation only supports Bits value of max 32."

    • When the implementation changes, for example supporting 64 bits, we can change it later.
  • Field's SubFieldSubtitution method now returning single value (*subField) instead of two (*subField, bool), since it will be nil anyway if no SubField is found.

  • Fix on SubFieldSubtitution should have continue to lookup instead of returning when 1 single map is not match.

  • Now when creating fields slice, we use fieldsArray [256]proto.Field as backing array for temporary slicing, this way we don't need to worry about component expansion re-triggering runtime.mallocgc causing performance overhead.

@muktihari muktihari added the bug Something isn't working label Dec 26, 2023
@muktihari muktihari self-assigned this Dec 26, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9774837) 100.00% compared to head (df3d210) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        27    +1     
  Lines         2986      2995    +9     
=========================================
+ Hits          2986      2995    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit cca8f0b into master Dec 26, 2023
1 check passed
@muktihari muktihari deleted the fix/decoder-component-expansion branch December 26, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants