Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.crc16.Write(b[:header.Size-2])
if the result of subtraction is negative, now we check the size early on and have fixed lene.crc16.Write(b[:12])
since we now the exact len. Now we used explicit slice indexes for crc, wasb[header.Size-2:]
nowb[12:14]
. If user passing header.Size < 12 it will be replaced by default one (header with size = 14). We only guard against something that might cause panic, if user still passing wrong size intentionally, so be it, it will not cause panic or error, only the fit file might not be read by other decoder.Put
method's docs.