fix: decoder slicing size byte overflow #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
n
is 123 expected value ofn*3
is 369, but since n is a byte with max value is 255, it overflows, the result is 113. This cause unexpected behaviour and even panic when trying to access the slice's index more than the available len, since the size does not match the correct size.Since the maximum of
bytesArray
is 766, an uint16 should be sufficient for this task.