Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encoder endianness #82

Merged
merged 2 commits into from
Jan 1, 2024
Merged

fix: encoder endianness #82

merged 2 commits into from
Jan 1, 2024

Conversation

muktihari
Copy link
Owner

@muktihari muktihari commented Jan 1, 2024

  • Encoder was not set endianness before encoding message, causing all message would not be encoded in little-endian byte order even thought WithBigEndian() option is specified.
  • Fix typo endianess should be endianness, missing n word

@muktihari muktihari added the bug Something isn't working label Jan 1, 2024
@muktihari muktihari self-assigned this Jan 1, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9ef1b8) 100.00% compared to head (6b559cd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         3101      3102    +1     
=========================================
+ Hits          3101      3102    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 0515bd4 into master Jan 1, 2024
1 check passed
@muktihari muktihari deleted the fix/encoder-endianness branch January 1, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants