Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excel file export, datetime changes #54

Merged
merged 3 commits into from
Aug 13, 2022

Conversation

sujeendran
Copy link
Contributor

Hi,
Thank you for building this tool! It is very helpful in my work. I have added few features that are useful for me and thought others also might find some use with it. Please feel free to review the changes and if you find them useful we can merge it.

Changes included:

  • Added support for Excel (*.xlsx) file export
  • Added an option to toggle short date format while exporting CSV.
  • Removed outdated dependency checks in ParquetViewer.csproj file.
  • Updated nuget packages.

Disclaimer: I don't think I have extensively tested support for all the data types for excel file export.

- Added support for Excel .xlsx file export
- Added an option to toggle short date format while exporting CSV.
@mukunku mukunku changed the base branch from master to v2.3.7 August 13, 2022 00:26
@mukunku mukunku merged commit ff2341c into mukunku:v2.3.7 Aug 13, 2022
@mukunku
Copy link
Owner

mukunku commented Aug 13, 2022

Thanks so much for the contribution. I created #58 now to get this released. I did end up making some changes:

  • I ditched xlsx and changed it to xls because the executable size was increasing from 1.5MB to 8MB with the ClosedXML package being included. I added a raw Excel writer so ended up not having to add any new packages
  • I added a bunch of date formats and made it so the date format in the export matches the date format on screen. While not ideal I think that's going to be the least confusing.

Really appreciate the effort you put into this; I wouldn't have been able to add these features if you hadn't.

@sujeendran
Copy link
Contributor Author

Glad to see the changes being including in the new release :) Also your changes make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants