Parse renamed files #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
added a commit
to dahlia/checkmate
that referenced
this pull request
Nov 3, 2017
dahlia
added a commit
to dahlia/checkmate
that referenced
this pull request
Nov 3, 2017
dahlia
added a commit
to dahlia/checkmate
that referenced
this pull request
Nov 3, 2017
|
The build was failed during installing hspec-discover library. Seems it uses too old version of hspec. Wouldn't it be better to use more recent version of hspec? Added: Oh, it already was reported as an issue #9. |
dahlia
force-pushed
the
parse-renamed-file
branch
from
cb86ec8 to
f43da00
Compare
|
Rebased the patch on the latest master, and the CI build succeeded as well! @mulby could you review this PR too? |
|
Looks great, thanks for the contribution! |
|
Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds
Renamedconstructor toFileStatustype and modifiesfileStatusfunction so that it can parse patterns such as the following diff:diff --git a/foo.txt b/bar.txt similarity index 100% rename from foo.txt rename to bar.txt