Pass count as keyword argument to re.sub()
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes two test failures under Python 3.13: ``` Failed Tests (2): FileCheck.py integration tests :: tests/extra_features/pseudo_numeric_variables/01_line_variable_once/test.itest FileCheck.py integration tests :: tests/extra_features/pseudo_numeric_variables/02_line_variable_twice/test.itest ``` Both are failing due to: ``` filecheck/filecheck.py:372: DeprecationWarning: 'count' is passed as positional argument ``` Passing `count` as positional argument to `re.sub()` has been deprecated in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#id9 and produces a `DeprecationWarning` exception.
|
Thank you for your contribution. I didn't upgrade the setup scripts for quite a while, and it looks like there is a failure unrelated to your change. Give me a few days to fix the issue, and I will get back to merging this. |
|
The newly released Pip version should have your fix: https://pypi.org/project/filecheck/. |
|
Thank you for your contribution! |
|
You're welcome and thanks for merging this so quickly. We have a proactive Python maintainers team that rebuilds all Python packages in Fedora with upcoming Python versions in advance to catch issues like this early. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two test failures under Python 3.13:
Both are failing due to:
Passing
countas positional argument tore.sub()has been deprecated in Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#id9 and produces aDeprecationWarningexception.