FilePathFilter: Allow combined include-path + exclude-path #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexDenisov
approved these changes
Sep 2, 2020
|
Thanks, @gebart. If you don't mind I'd like to take over this PR and push couple more commits on top to debug and fix the CI failure. |
|
Sure, feel free to update my branch with your changes. |
Include will be applied first, then excludes.
jnohlgard
force-pushed
the
include+exclude
branch
from
1bb46d9
to
13c0b7d
Compare
|
rebased to retrigger CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include will be applied first, then excludes.
If only include-path or only exclude-path is given then the behavior is unchanged from before.
This is useful if test code lives in the same tree as the code under test, so you can do
mull-cxx --include-path=mymodule --exclude-path=tests