Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: split data onto many files #5917

Closed
wants to merge 1 commit into from

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Mar 7, 2024

macos/data.rs is over 1000 LOC long. This PR aims to split data.rs onto multiple smaller files under macos/data which should be easier to maintain in the long term.

Since this looks like huge change, I'd suggest you to pull the branch and run:

git -c color.diff.newMoved=black -c color.diff.oldMoved=black diff --color-moved=plain --unified=0 head~1

which should show you the same code in black and then what was added/replaced/removed in green and red.

Please run and test these changes of course to make sure that I didn't break anything.


This change is Reviewable

@pronebird
Copy link
Contributor Author

pronebird commented Mar 7, 2024

On a side note, wanted to ask about the use of futures crate in routing. Is it some ancient relic that perhaps should be replaced with tokio which seems to be uber popular and almost ubiquitous these days?

@MarkusPettersson98
Copy link
Contributor

Hi @pronebird, thanks for your contribution! Since we didn't act on this in a timely manner, and multiple merge conflicts have arisen at this point. We have decided to close your PR, but we greatly appreciate your effort. It can very well serve as inspiration for future refactors 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants