Move to CollectSideEffectWithLifecycle #6587
Conversation
There was a problem hiding this comment.
Reviewed 18 of 18 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
This is blocked, we should address the last 4 remaining LuanchedEffectCollect
Reviewable status:
There was a problem hiding this comment.
Is this something can/should work on or should we mark it as "On hold"?
Reviewable status:
There was a problem hiding this comment.
There are some things that needs discussing, but we can put it on hold since we have other things that are more important.
Reviewable status:
Pururun
added
the
On hold
Rawa
force-pushed
the
ensure-we-use-collectsideeffectwithlifecycle-droid-1186
branch
from
bb37926
to
09181fc
Compare
Pururun
removed
the
On hold
Rawa
force-pushed
the
ensure-we-use-collectsideeffectwithlifecycle-droid-1186
branch
from
09181fc
to
93a7faf
Compare
There was a problem hiding this comment.
Reviewed 19 of 19 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status:
Rawa
force-pushed
the
ensure-we-use-collectsideeffectwithlifecycle-droid-1186
branch
from
93a7faf
to
0cdcfb8
Compare
Rawa
deleted the
ensure-we-use-collectsideeffectwithlifecycle-droid-1186
branch
This change is