Fix issues in new connection panel

[raksooo]

• Improve math for calculating whether or not an indicator should show.
• Fix connection panel closing without any actions
• Defer making feature indicators visible to ensure elements rendered

---

This change is 

[linear]

DES-1162 Feature indicators invisible in collapsed connection panel

[MarkusPettersson98]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raksooo)

---

gui/src/renderer/components/main-view/FeatureIndicators.tsx line 210 at r1 (raw file):

  const lineIndex = Math.round((indicatorRect.top - containerRect.top) / (LINE_HEIGHT + GAP));

  return lineIndex > 1 || (lineIndex === 1 && indicatorRect.right >= ellipsisSpacerRect.left);

Nit I kind of miss the old comment explaining that an indicator should be hidden if it overlaps the spacer ellipsis. Consider re-adding some version of the old comment 😊

Code quote:

  return lineIndex > 1 || (lineIndex === 1 && indicatorRect.right >= ellipsisSpacerRect.left);

[raksooo]

Reviewable status: complete! all files reviewed, all discussions resolved

---

gui/src/renderer/components/main-view/FeatureIndicators.tsx line 210 at r1 (raw file):

Previously, MarkusPettersson98 (Markus Pettersson) wrote…

Nit I kind of miss the old comment explaining that an indicator should be hidden if it overlaps the spacer ellipsis. Consider re-adding some version of the old comment 😊

Done.

[MarkusPettersson98]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved