Match no OpenVPN relays when core privacy features are enabled

[dlon]

WireGuard will always be preferred, when any of these features is enabled, even when the tunnel protocol is set to auto.

Core privacy features include PQ, multihop, and DAITA.

Close DES-1066.

---

This change is 

[linear]

DES-1066 Disable OpenVPN fallback when a core privacy feature is enabled

[hulthe]

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @dlon)

---

CHANGELOG.md line 31 at r2 (raw file):

### Changed
- OpenVPN is never used as a fallback protocol when any of the following features is enabled:
  multihop, quantum-resistant tunnels, or DAITA.

should have an imperative form

Suggestion:

Disable use of OpenVPN as a fallback protocol when any of the following features is enabled:

---

mullvad-relay-selector/src/relay_selector/matcher.rs line 168 at r2 (raw file):

/// Returns whether `relay` satisfy the daita constraint posed by `filter`.
pub fn filter_on_daita(filter: &Constraint<bool>, relay: &Relay) -> bool {

BTW I'd argue it's more type safe to pass the &WireguardRelayQuery instead of the bool constraint since it's such a non-specific type. Feel free to ignore if you disagree though

[dlon]

Reviewable status: 2 of 8 files reviewed, 3 unresolved discussions (waiting on @hulthe and @Serock3)

---

CHANGELOG.md line 31 at r2 (raw file):

Previously, hulthe (Joakim Hulthe) wrote…

should have an imperative form

Suggestion:

Disable use of OpenVPN as a fallback protocol when any of the following features is enabled:

Done.

[hulthe]

Reviewed 3 of 6 files at r3, 1 of 3 files at r4, all commit messages.
Reviewable status: 6 of 9 files reviewed, 2 unresolved discussions (waiting on @Serock3)

[Serock3]

Reviewed 1 of 6 files at r1, 1 of 1 files at r2, 2 of 6 files at r3, 2 of 3 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved