Export protocol codes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hsanjuan
reviewed
Dec 20, 2018
|
This codes are already exported as |
|
Good point. It does break the 'uniformity' of |
|
I don't think it hurts (it's a mild improvement), but you will have to Gx-bubble more things. |
ghost
assigned 
raulk
approved these changes
Feb 27, 2019
|
@backkem thanks for the contribution! 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export the protocol codes so they can be used in
whyrusleeping/mafmt.I also added the 'single source of truth' comment as in
go-multiaddr. I could not find a decision in this regard. Let me know if there is a single source of truth already, I can change the PR to reflect it.