update golang.org/x/exp, fixing slice sorting to match standard library #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking about it more, this should probably just be closed unless a critical mass of projects want to use the new exp/slices package, or until everyone adopts Go 1.21 standard slices, making this PR moot |
|
@cce Why are you closing this PR? |
|
oh OK! I'll re-open it — I started to think it might be more trouble than it was worth |
marten-seemann
approved these changes
Aug 3, 2023
marten-seemann
changed the title
21 tasks
|
Thank you @cce! This will be included in the go-libp2p v0.30 release. |
|
Dupe of #207 |
This was referenced Aug 9, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the dependency on the slices package from golang.org/x/exp used here to match the upcoming Go 1.21 standard library API, which uses a different comparison function.
golang/exp@302865e
golang/go#61374