Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add new emoji codepoint for Base256Emoji 🐉 #52

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

Jorropo
Copy link
Contributor

@Jorropo Jorropo commented Jun 13, 2022

One of the values of base256emoji was not actually an emoji.

Here there be dragons instead !

See df5b7bc#r75683795 for context.

Blocked on: multiformats/multibase#98

@Jorropo Jorropo force-pushed the emoji-emoji-base branch 5 times, most recently from beaed77 to 6e316c1 Compare June 13, 2022 21:03
@Jorropo Jorropo changed the title fix: add new emoji codepoint for Base256Emoji fix: add new emoji codepoint for Base256Emoji 🐉 Jun 13, 2022
One of the values of base256emoji was not actually an emoji.

Here there be dragons instead !

See multiformats@df5b7bc#r75683795 for context.
@Jorropo
Copy link
Contributor Author

Jorropo commented Jun 16, 2022

@rvagg since multiformats/multibase#98 has been merged, this is also ready to merge.
Could you review this pls ? 🙂

@rvagg rvagg merged commit c1bc15b into multiformats:master Jun 17, 2022
@Jorropo Jorropo deleted the emoji-emoji-base branch June 17, 2022 01:15
@BigLep BigLep mentioned this pull request Jul 26, 2022
68 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants