feat: Add /p2p-stardust #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkg20001
commented
Jan 11, 2019
This was referenced Jan 11, 2019
mkg20001
force-pushed
the
add-stardust
branch
2 times, most recently
from
ebaa240
to
386049c
Compare
This is part of the endeavor to replace ws-star with the newly created stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a reference Note: This PR depends on this pr to be merged and the package being updated first: multiformats/js-multiaddr#78
mkg20001
force-pushed
the
add-stardust
branch
from
386049c
to
b7a4387
Compare
|
This is now ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the endeavor to replace ws-star with the newly created
stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a
reference
Note: This PR depends on this pr to be merged and the package being
updated first: multiformats/js-multiaddr#78
Also note that this pr currently has failing tests that seem unrelated to my changesfixed (I've added some code to make debugging them easier)