feat: multiaddr support Peer ID represented as CID #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for Peer ID represented as CID. Implements `Stage 1` from libp2p/specs#216 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements
Stage 1: Parse CIDs as peer IDfrom libp2p/specs#216.TL;DR This PR does not change the format returned by
getPeerId(), all we do inStage 1is adding support for Peer IDs represented with CIDs in text form.For a wider context see libp2p/specs/RFC/0001-text-peerid-cid.md, short story is that CID support will enable IPFS project to support
/ipns/{cid}in Base32 (https://github.com/ipfs/ipfs/issues/337), enabling things likehttp://{libp2p-key-as-cidv1b32}.ipns.dweb.linkChanges
This PR modifies
getPeerId()to add support for Peer IDs as CIDs.(libp2p RFC 0001)
Next
createFromCIDcc https://github.com/ipfs/ipfs/issues/337, libp2p/specs#216, libp2p/specs#209