feat: Add webtransport component #271
Conversation
| @@ -346,6 +346,13 @@ describe('variants', () => { | |||
| expect(addr.toString()).to.equal(str) | |||
| }) | |||
|
|
|||
| it('webtransport', () => { | |||
| const str = '/ip6/2001:8a0:7ac5:4201:3ac9:86ff:fe31:7095/udp/4001/quic/webtransport' | |||
There was a problem hiding this comment.
Is WebTransport always ipv6? If not, please add a ipv4 test as well to make future selves grateful to current selves.
There was a problem hiding this comment.
Honest question, does this matter? Is it possible to get parsing failure if an earlier protocol is different? My understanding is as far as this library is concerned it doesn't care if the multiaddr is valid or not. It just parses the multiaddr into parts.
There was a problem hiding this comment.
Is it possible to get parsing failure if an earlier protocol is different?
It's hard to say for sure now without a test and impossible to say for the future.
IPv4 is likely to be the most common input so it seems reasonable to have a test that exercises it, which would also then be consistent with the other tests in the file.
## [10.5.0](v10.4.3...v10.5.0) (2022-09-20) ### Features * Add webtransport component ([#271](#271)) ([210f156](210f156))
|
🎉 This PR is included in version 10.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This adds the webtransport protocol here