feat: accept DNS resolver when resolving DNSADDR addresses #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept a `DNS` instance from `@multiformats/dns` when resolving DNSADDR addresses. Gives the user flexibility to control which DNS servers are used to resolve TXT records.
SgtPooki
approved these changes
Mar 10, 2024
| import { dnsJsonOverHttps } from '@multiformats/dns/resolvers' | ||
|
|
||
| const resolver = dns({ | ||
| '.': dnsJsonOverHttps('https://cloudflare-dns.com/dns-query') |
There was a problem hiding this comment.
Might be worth calling out what the dot here is for, or adding example with more specific tld resolver
There was a problem hiding this comment.
I've linked to the @multiformats/dns docs to avoid replicating them here.
achingbrain
deleted the
feat/accept-dns-resolver-when-resolving-dnsaddrs
branch
github-actions bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
## [12.2.0](v12.1.14...v12.2.0) (2024-03-11) ### Features * accept DNS resolver when resolving DNSADDR addresses ([#373](#373)) ([9b2df99](9b2df99)) ### Trivial Changes * add or force update .github/workflows/js-test-and-release.yml ([#371](#371)) ([f61dec7](f61dec7)) * update project ([#372](#372)) ([9ce73b2](9ce73b2))
|
🎉 This PR is included in version 12.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
related to ipfs/helia-verified-fetch#13 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept a
DNSinstance from@multiformats/dnswhen resolving DNSADDR addresses.Gives the user flexibility to control which DNS servers are used to resolve TXT records.