feat: use class-is module for type checks #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fsdiogo Do I understand it correctly that |
|
@vmx yes, you got it! That’s why I removed that function. |
vmx
approved these changes
Mar 30, 2018
|
Let's wait on merging things to wait @fsdiogo confirming that the solution is complete and sound. |
daviddias
reviewed
Mar 31, 2018
| @@ -44,7 +43,7 @@ function Multiaddr (addr) { | |||
| } else { | |||
| throw new Error('addr must be a string, Buffer, or another Multiaddr') | |||
| } | |||
| } | |||
| }, { className: 'Multiaddr', symbolName: '@multiformats/js-multiaddr/multiaddr' }) | |||
There was a problem hiding this comment.
@fsdiogo instead of adding it at the top (which makes it look like a 👽 function declaration for folks non familiar with the whole situation), do the withIs.proto a separate statement before the module exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an ongoing effort to fix the ipfs/js-ipfs#938 issue.
It uses a module I've published that abstracts this solution: ipfs/js-ipfs#1131 (comment).