Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add test for structural copying #206

Merged
merged 5 commits into from
Oct 4, 2022

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Oct 3, 2022

This adds a test test that is expected to fail on #202 because getters on prototypes aren't going to be retained when moving things across JS realms. Use of getter on the instance or actual property does not has this problem.

test/test-cid.spec.js Outdated Show resolved Hide resolved
test/test-cid.spec.js Outdated Show resolved Hide resolved
Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, good test, let's make it pass then and I suppose a regular property it is (for now)

@rvagg rvagg merged commit 481b140 into fix/remove-cid-define-properties Oct 4, 2022
@rvagg rvagg deleted the chore/add-cid-move-test branch October 4, 2022 22:28
rvagg pushed a commit that referenced this pull request Oct 8, 2022
* chore: add test for structural copying

* fix: remove generated import

* fix: lint errors

* fix: another attempt to make eslint happy

* chore: and another attemp to make eslint happy
rvagg pushed a commit that referenced this pull request Oct 8, 2022
* chore: add test for structural copying

* fix: remove generated import

* fix: lint errors

* fix: another attempt to make eslint happy

* chore: and another attemp to make eslint happy
rvagg pushed a commit that referenced this pull request Oct 12, 2022
* chore: add test for structural copying

* fix: remove generated import

* fix: lint errors

* fix: another attempt to make eslint happy

* chore: and another attemp to make eslint happy
rvagg pushed a commit that referenced this pull request Oct 12, 2022
* chore: add test for structural copying

* fix: remove generated import

* fix: lint errors

* fix: another attempt to make eslint happy

* chore: and another attemp to make eslint happy
github-actions bot pushed a commit that referenced this pull request Oct 12, 2022
## [10.0.0](v9.9.0...v10.0.0) (2022-10-12)

### ⚠ BREAKING CHANGES

* remove use of Object.defineProperties in CID class
* use aegir for ESM-only build/testing/release

### Features

* add complete set of aegir-based scripts ([1190bc6](1190bc6))
* define Link interface for CID ([88e29ea](88e29ea))
* remove deprecated CID properties & methods ([ffc4e6f](ffc4e6f))
* use aegir for ESM-only build/testing/release ([163d463](163d463))

### Bug Fixes

* --no-cov for all but chrome main ([b92f25f](b92f25f))
* add "browser" field, remove named local imports ([d60ea06](d60ea06))
* additional lint items from Link interface work ([91f677b](91f677b))
* address JS & TS linting complaints ([c12db2a](c12db2a))
* changes for new lint rules ([e6c9957](e6c9957))
* distribute types in dist/types/ ([c6defdb](c6defdb))
* ensure "master" as release branch ([16f8d9e](16f8d9e))
* make CID#asCID a regular property ([a74f1c7](a74f1c7))
* only release on master ([d15f26f](d15f26f))
* properly export types, build more complete pack ([8172ea8](8172ea8))
* remove "main" ([ad3306c](ad3306c))
* remove use of Object.defineProperties in CID class ([6149fae](6149fae)), closes [#200](#200)
* run coverage only where it's supposed to ([872d121](872d121))
* test on all branches and pull requests ([f2ae077](f2ae077))
* ts-use import path ([53651c1](53651c1))
* use extensions for relative ts imports ([451998a](451998a)), closes [/github.com//pull/199#issuecomment-1252793515](https://github.com/multiformats//github.com/multiformats/js-multiformats/pull/199/issues/issuecomment-1252793515)
* use parent `tsc` in ts-use ([85a9296](85a9296))

### Tests

* check for non-enumerability of asCID property ([b4ba07d](b4ba07d))

### Trivial Changes

* add test for structural copying ([#206](#206)) ([e8def36](e8def36))
* **no-release:** bump @types/mocha from 9.1.1 to 10.0.0 ([#205](#205)) ([a9a9347](a9a9347))
* **no-release:** bump actions/setup-node from 3.4.1 to 3.5.0 ([#204](#204)) ([604ca1f](604ca1f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants