fix: CID.parse(base36) #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to support base36 out of the box, without having to specify the 'base' parameter explicitly. Rationale is that base36 is used across ecosystem for PeerIDs that have to be represented in base36 to fit in a single DNS label (due to limit of 63 characters).
lidel
force-pushed
the
fix/cid-parde-base36
branch
from
2f737ad
to
daf1874
Compare
rvagg
approved these changes
Aug 26, 2024
achingbrain
approved these changes
Sep 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
## [13.2.3](v13.2.2...v13.2.3) (2024-09-12) ### Bug Fixes * CID.parse(base36) ([#307](#307)) ([892f198](892f198))
|
🎉 This PR is included in version 13.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support base36 out of the box, without having to specify base explicitly.
Rationale is that base36 is used across ecosystem for PeerIDs that have to be represented in base36 to fit in a single DNS label (due to limit of 63 characters).