Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

add .verify() for one-stop verification of a buffer against a hash #5

Closed
wants to merge 1 commit into from

Conversation

candeira
Copy link

@candeira candeira commented Jan 7, 2016

Rationale: .verify() will likely be the most frequent operation, so it should be a shared utility function, not something endlessly reimplemented.

There are tests (they pass) and the library is lint clean. However, I didn't run a zuul test because I didn't have credentials.

@candeira candeira changed the title add verify() for one-stop verification of a buffer against a hash add .verify() for one-stop verification of a buffer against a hash Jan 7, 2016
@daviddias
Copy link
Member

@candeira try npm run test:browser:q for testing locally in a browser (change version of Chrome to the latest (nowadays is 47) ) https://github.com/jbenet/js-multihashing/blob/master/package.json#L10)

@candeira
Copy link
Author

candeira commented Jan 9, 2016

@diasdavid I tried, but npm run test:browser:q doesn't test locally, but just injects some values in environment variables, then calls run test:browser, which calls on zuul, which again requires saucelab credentials.

@daviddias
Copy link
Member

@candeira you are right, forgot about that step :)

@harlantwood
Copy link
Contributor

+1 for .verify(...)

@daviddias
Copy link
Member

Hi @candeira, seems that this module has changed a ton since your PR, could you rebase it on top of current master?

Thank you!

@daviddias
Copy link
Member

ping @candeira

@daviddias daviddias added the status/ready Ready to be worked label Dec 5, 2016
@daviddias daviddias added status/deferred Conscious decision to pause or backlog exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue and removed js-ipfs-backlog status/ready Ready to be worked labels Jan 29, 2017
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Oct 17, 2017
@daviddias
Copy link
Member

@candeira still interested in pushing this PR?

@daviddias daviddias added the P3 Low: Not priority right now label Oct 17, 2017
@hacdias
Copy link
Member

hacdias commented Jan 2, 2018

@diasdavid is the idea of implementing the .verify() function still alive?

@hacdias hacdias mentioned this pull request Jan 9, 2018
@daviddias daviddias closed this in #26 Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants