-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no_std Compatibility #30
Conversation
I just merged #27. BTW, you want to mention @whalelephant instead :) |
ah thanks, took glasses off for a minute and didnt bother to read the whole thing... |
@vmx it might be good to add some info in README and adding 'no_std' to the cargo tags- things like that before merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I make this a "request changes" due to the git based dependency of the base-x-rs fork.
@mriise feel free to add the "no_std" tag as part of this PR.
@vmx after this PR could we get a |
Yes we should. I tried things locally and I think we should use the |
Like this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest looks good!
There we go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work and fighting CI!
Waiting for #27 for me to keep sanity over changes.fixes #24 thanks to work done by @whalelephant and @ia0 over in #25
This allows multibase to only require a global allocator in no_std environments.