This repository has been archived by the owner on Jul 7, 2023. It is now read-only.
C4-300: Add storage gap to ERC20, ERC4626, BaseUpgradeable #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d889791.
…rt time (#215) * added creation time for cancel fix * added this back because recreateMinipool uses it * review comments * missed this
…45)" (#267) This reverts commit 8b92375.
…ards start time (#215)" (#269) This reverts commit 7138ae3.
This reverts commit 966d8ce.
…unds (#245)" (#267)" This reverts commit 6022595.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C4 issues
code-423n4/2022-12-gogopool-findings#300
code-423n4/2022-12-gogopool-findings#329
Adds a storage gap so future versions of ERC20 and ERC4626 do not shift storage in the inheritance chain. Also going to add to BaseUpgradeable