Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance PDF Report with Detailed Financial Summary and Dynamic Plot Inclusion #114 #116

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

Ananya-vastare
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Also, explain the motivation behind this PR.
This PR enhances the visual aesthetics of the financial summary report by improving both the pie and line charts, as well as the PDF layout. The pie chart now features a modern Seaborn pastel color palette, shadow effects for a 3D appearance, and clearer wedge borders for better readability. The line chart has been updated with larger markers, smoother lines, and a refined grid to ensure clarity. Additionally, bolder titles and labels were applied to improve presentation. These enhancements are integrated into the PDF, which now includes the dynamically generated high-resolution plot, ensuring a professional, polished report. The motivation behind this PR is to address the original issue of basic, cluttered visuals, making the financial data easier to interpret and more appealing to present. These updates align with modern data visualization standards and significantly improve the user experience by delivering a clearer, more professional report output.

Related Issue

Fixes # (issue)114

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • [ X] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • [X ] My code follows the style guidelines of this project
  • [ X] I have performed a self-review of my own code
  • [X ] I have commented on my code, particularly in hard-to-understand areas
  • [X ] I have added tests that prove my fix is effective or that my feature works
  • [X ] New and existing unit tests pass locally with my changes
  • [X ] Any dependent changes have been merged and published in downstream modules
    John Doe-2024-10-11.pdf

Copy link

netlify bot commented Oct 11, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit a10f4a4
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/670e4c0810fd5400088d2cdc
😎 Deploy Preview https://deploy-preview-116--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jency1 jency1 requested a review from multiverseweb October 12, 2024 18:19
@Ananya-vastare
Copy link
Contributor Author

@multiverseweb any updates please??

Copy link
Owner

@multiverseweb multiverseweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Ananya-vastare, sorry for the delay. In this PR, you have initialized the values to be plotted and used them to generate the report. Also, you have explicitly used the name "John Doe" for naming the pdf file. Here are the requirements that issue #114 and a much older similar issue #5 request:

  • Create a pdf with the name username-currentDate-Dataverse.pdf.
  • Take corresponding live data from mysql database.
  • The report must contain the date, username, image of the line chart, pie chart, bar graph and the name Dataverse with logo.

@Ananya-vastare
Copy link
Contributor Author

@multiverseweb will make the necessary changes

@Ananya-vastare
Copy link
Contributor Author

@multiverseweb I have made the desired changes please let me know if I have to change anything else thank you

@multiverseweb
Copy link
Owner

@multiverseweb I have made the desired changes please let me know if I have to change anything else thank you

Hey @Ananya-vastare, I've been busy lately. Will check it out as soon as I get time.
Sorry for the inconvenience.

@Ananya-vastare
Copy link
Contributor Author

@multiverseweb any updates please

@multiverseweb
Copy link
Owner

multiverseweb commented Oct 22, 2024

Yes, this looks fine. Thanks for your contribution @Ananya-vastare.
If you want to work on this further, create a new issue to integrate this report generation feature with the software's GUI.

@multiverseweb multiverseweb merged commit dbc2897 into multiverseweb:main Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants