New libp2p versions #42

iulianpascalau · 2023-06-07T07:07:37Z

updated libp2p libraries to the following versions & golang v1.20.3 compiler accommodations:

github.com/libp2p/go-libp2p v0.28.1
github.com/libp2p/go-libp2p-kad-dht v0.23.0
github.com/libp2p/go-libp2p-kbucket v0.6.3
github.com/libp2p/go-libp2p-pubsub v0.9.3
github.com/multiformats/go-multiaddr v0.9.0

…instance

sstanculeanu · 2023-06-08T07:16:55Z

libp2p/netMessenger_test.go

+			assert.Equal(t, "/ip4/127.0.0.1/tcp/100", addresses[0])
+			assert.Nil(t, err)
+		})
+		t.Run("without port reuse, should work", func(t *testing.T) {


Suggested change

t.Run("without port reuse, should work", func(t *testing.T) {

t.Run("with port reuse, should work", func(t *testing.T) {

sstanculeanu · 2023-06-08T07:37:38Z

integrationTests/peerConnections/peerConnections_test.go

+	require.Nil(t, err)
+	addressToConnect = getAddressMatching(seeder.Addresses(), "/quic-v1/", "")
+	err = webTransportPeer.ConnectToPeer(addressToConnect)
+	fmt.Println(webTransportPeer.ID().Pretty())


is this needed or debug purpose only?

initial debug. Removed

sstanculeanu · 2023-06-08T07:44:53Z

integrationTests/peerConnections/peerConnections_test.go

+
+	mutMessages.Unlock()
+
+	defer func() {


remove defer?

right, removed

sstanculeanu · 2023-06-08T14:53:13Z

libp2p/netMessenger.go

+		}
+	}
+
+	quickAddress := configs.QUICAddress


Suggested change

quickAddress := configs.QUICAddress

quicAddress := configs.QUICAddress

p-shahi · 2023-06-29T19:58:22Z

integrationTests/peerConnections/peerConnections_test.go

+
+	quicPeerArgs := createBaseArgs()
+	quicPeerArgs.P2pConfig.Node.Transports = config.TransportConfig{
+		QUICAddress: "/ip4/127.0.0.1/udp/%d/quic",


👋 Hi, I discovered this PR from this tweet
It is awesome to see QUIC and WebTransport being added!

A drive-by suggestion I have is to use quic-v1 for QUIC multiaddresses. /quic/ is the draft-29 version of the address and go-libp2p is planning on removing support for it in the next release libp2p/go-libp2p#2369
So it would make sense for any new QUIC deployment to use quic-v1 right away

Also, you are already using quic-v1 for your WebTransport addresses; using it in both places would enable inferring WebTransport listen addrs from observation (via Identify) of quic-v1 addrs libp2p/go-libp2p#2251

Thanks for the heads-up!
Will change the mutiaddress to use quic-v1 instead of plain quic

done & pushed

- removed unnecessary replace in go.mod

dragos-rebegea · 2023-06-30T12:41:45Z

libp2p/peersOnChannel.go

@@ -102,6 +103,9 @@ func (poc *peersOnChannel) refreshPeersOnAllKnownTopics(ctx context.Context) {
 		case <-time.After(poc.refreshInterval):
 		}

+		//TODO remove this


is the TODO meant to be done in a future PR?

rechecking all PR

- removed TODOs

raduchis · 2023-07-04T08:07:51Z

.github/workflows/pr-tests.yml

@@ -11,10 +11,10 @@ jobs:
    name: Unit tests without race detector
    runs-on: ubuntu-latest
    steps:
-      - name: Set up Go 1.17.6
+      - name: Set up Go 1.20.3


maybe update to 1.20.5, latest stable.
Also all workflows should be updated.

raduchis · 2023-07-04T09:04:31Z

libp2p/netMessenger.go

@@ -37,7 +41,7 @@ import (

 const (
 	// TestListenAddrWithIp4AndTcp defines the local host listening ip v.4 address and TCP used in testing
-	TestListenAddrWithIp4AndTcp = "/ip4/127.0.0.1/tcp/"
+	TestListenAddrWithIp4AndTcp = "/ip4/127.0.0.1/tcp/%d"


could this be moved to a test file?

iulianpascalau added 7 commits June 7, 2023 10:06

- try new version

a764359

- try new version

d207f69

- no extra parameters on the host creation

7812c52

- new setting

424bc77

- added the possibility to use multiple transports in a netMessenger …

71d133b

…instance

- fixed tests

bb28040

- skipping a long test

1405694

sstanculeanu self-requested a review June 8, 2023 07:01

sstanculeanu reviewed Jun 8, 2023

View reviewed changes

miiu96 previously approved these changes Jun 8, 2023

View reviewed changes

sstanculeanu reviewed Jun 8, 2023

View reviewed changes

- fixes after review

94ba35e

iulianpascalau dismissed miiu96’s stale review via 94ba35e June 9, 2023 07:48

sstanculeanu previously approved these changes Jun 9, 2023

View reviewed changes

miiu96 previously approved these changes Jun 9, 2023

View reviewed changes

- put back some options

c8d7438

iulianpascalau dismissed stale reviews from miiu96 and sstanculeanu via c8d7438 June 14, 2023 12:44

iulianpascalau added 12 commits June 19, 2023 18:25

- added debug prints

31f0c39

- replaced with fork

9e33ed6

- replaced with fork & try possible fix 2

acec5ee

- reverted possible fix 2

769557c

- trying fix number 3: do not close or reset the direct sender streams

812686d

- new logs in pubsub

1c690f2

- new pubsub repo

4e85ecc

- try new fix

f46a768

- try new fix

eb2aab1

-more fixes

0423acd

- try replace

21754ab

- new public libraries

70490be

p-shahi reviewed Jun 29, 2023

View reviewed changes

iulianpascalau marked this pull request as ready for review June 30, 2023 12:08

- replaced quic with quic-v1

d25ba39

- removed unnecessary replace in go.mod

miiu96 previously approved these changes Jun 30, 2023

View reviewed changes

dragos-rebegea reviewed Jun 30, 2023

View reviewed changes

- minor logging fixes

8189d3c

- removed TODOs

iulianpascalau dismissed miiu96’s stale review via 8189d3c June 30, 2023 14:42

dragos-rebegea previously approved these changes Jun 30, 2023

View reviewed changes

miiu96 previously approved these changes Jul 4, 2023

View reviewed changes

raduchis reviewed Jul 4, 2023

View reviewed changes

- fixes after review

38ba79c

iulianpascalau dismissed stale reviews from miiu96 and dragos-rebegea via 38ba79c July 4, 2023 12:17

raduchis approved these changes Jul 4, 2023

View reviewed changes

dragos-rebegea approved these changes Jul 4, 2023

View reviewed changes

miiu96 approved these changes Jul 4, 2023

View reviewed changes

sstanculeanu approved these changes Jul 7, 2023

View reviewed changes

iulianpascalau marked this pull request as draft July 7, 2023 07:07

iulianpascalau marked this pull request as ready for review August 11, 2023 09:36

AdoAdoAdo approved these changes Aug 11, 2023

View reviewed changes

iulianpascalau merged commit 2dcca30 into master Aug 11, 2023

iulianpascalau deleted the try-new-libs branch August 11, 2023 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New libp2p versions #42

New libp2p versions #42

iulianpascalau commented Jun 7, 2023 •

edited

Loading

sstanculeanu Jun 8, 2023

iulianpascalau Jun 9, 2023

sstanculeanu Jun 8, 2023

iulianpascalau Jun 9, 2023

sstanculeanu Jun 8, 2023

iulianpascalau Jun 9, 2023

sstanculeanu Jun 8, 2023

iulianpascalau Jun 9, 2023

p-shahi Jun 29, 2023

iulianpascalau Jun 30, 2023 •

edited

Loading

iulianpascalau Jun 30, 2023

dragos-rebegea Jun 30, 2023

iulianpascalau Jun 30, 2023

raduchis Jul 4, 2023

raduchis Jul 4, 2023

	t.Run("without port reuse, should work", func(t *testing.T) {
	t.Run("with port reuse, should work", func(t *testing.T) {

	quickAddress := configs.QUICAddress
	quicAddress := configs.QUICAddress

New libp2p versions #42

New libp2p versions #42

Conversation

iulianpascalau commented Jun 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iulianpascalau Jun 30, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iulianpascalau commented Jun 7, 2023 •

edited

Loading

iulianpascalau Jun 30, 2023 •

edited

Loading