linter and grammar fixes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdan-rosianu
added
the
cleanup
andreibancioiu
approved these changes
Oct 11, 2022
| @@ -9,7 +9,8 @@ import ( | |||
| "github.com/ElrondNetwork/rosetta/server/resources" | |||
| ) | |||
|
|
|||
| type networkProvider interface { | |||
| // NetworkProvider defines the actions that need to be performed by the component that handles network data fetching | |||
| type NetworkProvider interface { | |||
There was a problem hiding this comment.
Here it should have been private (un-exported), though.
There was a problem hiding this comment.
no, according to the linter, since you return an unexported item within an exported function
| @@ -61,9 +61,9 @@ func TestTransactionsTransformer_UnsignedTxToRosettaTx(t *testing.T) { | |||
|
|
|||
| txsInBlock := []*transaction.ApiTransactionResult{refundTx, moveBalanceTx} | |||
|
|
|||
| rosettaFefundTx := transformer.unsignedTxToRosettaTx(refundTx, txsInBlock) | |||
| rosettaRefundTx := transformer.unsignedTxToRosettaTx(refundTx, txsInBlock) | |||
mariusmihaic
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed some linter and grammar issues