Integrate walletconnect #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @property({ type: Boolean }) isOpen = false; | ||
| @property({ type: String }) qrCodeData = ''; | ||
|
|
||
| static styles = css` |
There was a problem hiding this comment.
is it mandatory to pe statically defined here? Do you think it could be better to extract in a separate file ?
| onClientLogin: async function () { | ||
| closeModal(); | ||
| const address = provider.getAddress(); | ||
| console.log(`onClientLogin(), address: ${address}`); |
There was a problem hiding this comment.
still need this log ?
| console.log(`onClientLogin(), address: ${address}`); | ||
| }, | ||
| onClientLogout: function () { | ||
| console.log('onClientLogout()'); |
There was a problem hiding this comment.
maybe// TODO instead of logs ?
| const { uri, approval } = await provider.connect(); | ||
|
|
||
| if (!uri) { | ||
| throw 'URI not found'; |
There was a problem hiding this comment.
this throw will be caught outside, where the login function is called since the throw inside the catch will be caught in the catch block here, in the function...is it intended? Do you think is better to have a uniform way to handle the error exceptions?
| const signature = account?.signature; | ||
|
|
||
| if (!account) { | ||
| throw new Error(`Connection Proposal Refused ${account}`); |
There was a problem hiding this comment.
this throw will be caught at the line:80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
Additional changes
Contains breaking changes
[x] No
[] Yes
Updated CHANGELOG
[x] Yes
Testing
[x] User testing
[] Unit tests