Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transactions interpretation utils #38

Closed
wants to merge 26 commits into from

Conversation

razvantomegea
Copy link

No description provided.

CiprianDraghici and others added 13 commits August 29, 2024 19:16
# Conflicts:
#	src/apiCalls/transactions/getTransactionByHash.ts
#	src/apiCalls/transactions/getTransactionsByHashes.ts
#	src/constants/transactions.constants.ts
#	src/store/actions/network/initializeNetwork.ts
#	src/store/selectors/networkSelectors.ts
#	src/store/slices/index.ts
#	src/store/store.types.ts
#	src/types/index.ts
#	src/types/transactions.types.ts
#	src/utils/account/index.ts
#	src/utils/transactions/dataDecoders/smartContractTransaction.ts
@razvantomegea razvantomegea changed the title Transactions Transactions interpretation utils Dec 4, 2024
@@ -7,7 +7,7 @@ import {
} from 'store/actions/account/accountActions';
import { networkSelector } from 'store/selectors';
import { getStore } from 'store/store';
import { retryMultipleTimes } from 'utils/retryMultipleTimes';
import { retryMultipleTimes } from 'utils/misc/retryMultipleTimes';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this?

cancelled = 'cancelled'
}

export enum LoginMethodsEnum {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this must no longer exist

import { stringIsInteger } from '../validation';
import { pipe } from './pipe';

BigNumber.config({ ROUNDING_MODE: BigNumber.ROUND_FLOOR });
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use local instance of bigNumber with .copy

@@ -0,0 +1,37 @@
import { TransactionServerStatusesEnum } from 'types';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use index files?

@@ -0,0 +1,11 @@
import { getWindowLocation } from 'utils/window/getWindowLocation';

export function getScResultsHighlight(resultHash: string) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to utils?

@@ -1,2 +1,3 @@
export const isWindowAvailable = () =>
typeof window != 'undefined' && typeof window?.location != 'undefined';
export function isWindowAvailable() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the file name

@@ -1,2 +1,3 @@
export const isWindowAvailable = () =>
typeof window != 'undefined' && typeof window?.location != 'undefined';
export function isWindowAvailable() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

* @param options.removeParams allows removing params from URL search object
* @returns the selected params, search object with removed params, and the `clearNavigationHistory` helper
*/
export function parseNavigationParams(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

search?: string;
}

export function removeSearchParamsFromUrl({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@@ -1,7 +1,7 @@
export const sanitizeCallbackUrl = (
export function sanitizeCallbackUrl(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@razvantomegea razvantomegea marked this pull request as draft December 5, 2024 13:19
…rovider' into rt/feature/transactions

# Conflicts:
#	src/core/providers/ProviderFactory.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants