Add provider strategy #46

mgavrila · 2024-12-11T15:09:51Z

Proposal

Change function based provider creation into classes.
Provider creation logic is contained inside the class.

Usage:
const providerInstance = new WalletConnectProviderStrategy( walletConnect );
const provider = await providerInstance.createProvider();

src/core/providers-strategy/CrossWindowProviderStrategy.ts

src/core/providers-strategy/CustomProviderStrategy.ts

src/core/providers-strategy/WalletConnectProviderStrategy.ts

src/core/providers/DappProvider/helpers/signTransactions/helpers/getGuardedTransactions.ts

src/core/providers/ProviderFactory.ts

src/core/providers-strategy/CrossWindowProviderStrategy.ts

src/core/providers-strategy/ExtensionProviderStrategy.ts

src/core/providers-strategy/IFrameProviderStrategy.ts

src/core/providers-strategy/WalletConnectProviderStrategy.ts

src/core/providers/ProviderFactory.ts

src/core/providers-strategy/CustomProviderStrategy.ts

src/core/providers-strategy/CrossWindowProviderStrategy.ts

src/core/providers/ProviderFactory.ts

src/core/providers-strategy/CustomProviderStrategy.ts

src/core/providers/ProviderFactory.ts

src/types/provider.types.ts

…trategy

arhtudormorar · 2024-12-16T08:39:28Z

src/core/providers-strategy/CrossWindowProviderStrategy.ts

+      throw new Error(ProviderErrorsEnum.notInitialized);
+    }
+
+    if (!isBrowserWithPopupConfirmation) {


Did this should be configurable since we don't know all the browsers and maybe the user is using a different browser and needs the pop-up confirmation for it

arhtudormorar · 2024-12-16T09:08:13Z

src/core/providers-strategy/LedgerProviderStrategy.ts

+      ) => Promise<Transaction[]>)
+    | null = null;
+
+  constructor(address: string) {


you actually need addressIndex from the store

arhtudormorar · 2024-12-16T09:09:12Z

src/core/providers-strategy/LedgerProviderStrategy.ts

-        throw err;
-      }
+          if (eventBus) {
+            eventBus.unsubscribe(


eventbus?.unsubscribe ?

arhtudormorar · 2024-12-16T09:10:06Z

src/core/providers-strategy/LedgerProviderStrategy.ts


-  const hwProviderLogin = provider.login;
+    const provider = this.provider as unknown as IProvider;
+    provider.setAccount({ address: this.address });


you should also set addressIndex in HWProvider

arhtudormorar · 2024-12-16T09:11:29Z

src/core/providers-strategy/LedgerProviderStrategy.ts

-    document.body.appendChild(signModalElement);
-    await customElements.whenDefined('sign-transactions-modal');
+    if (shouldInitiateLogin) {
+      eventBus = await getEventBus('ledger-connect-modal');


there should always be a one-way flow between opening the modal and getting the event bus. I can't see the need of a split

+ there is a different eventBus for signing transactions

arhtudormorar · 2024-12-16T09:17:23Z

src/core/providers/ProviderFactory.ts

-        createdProvider.getType = () => ProviderTypeEnum.ledger;
-
-        await createdProvider.init?.();
+        const providerInstance = new LedgerProviderStrategy(address);


same question for all

arhtudormorar · 2024-12-16T09:18:08Z

src/core/providers/ProviderFactory.ts

-
-        createdProvider = provider as unknown as IProvider;
+        const providerInstance = new WalletConnectProviderStrategy(
+          walletConnectConfig


can this be fetched as a default from store inside the strategy?

arhtudormorar · 2024-12-16T09:18:31Z

src/core/providers/types/providerFactory.types.ts

@@ -42,13 +41,6 @@ export interface IProviderConfig {
    address: string;
  };
  UI?: IProviderConfigUI;


UI should be removed

src/utils/modalEvent.ts

arhtudormorar · 2024-12-16T09:20:04Z

src/utils/modalEvent.ts

+import { safeWindow } from 'constants/index';
+import { defineCustomElements } from 'lib/sdkDappCoreUi';
+
+export const getModalElement = async <


createModalElement?

arhtudormorar · 2024-12-16T11:36:18Z

src/core/methods/initApp/initApp.types.ts

@@ -16,6 +18,8 @@ type BaseDappConfigType = {
   * default: `true`
   */
  enableTansactionTracker?: boolean;
+  crossWindow?: CrossWindowConfig;


should we make like providers: {walletconnect, crossWindow } ?

arhtudormorar · 2024-12-16T11:36:56Z

src/core/providers-strategy/CrossWindowProviderStrategy.ts

+  private _signMessage: ((messageToSign: Message) => Promise<Message>) | null =
+    null;
+
+  constructor(address?: string, walletAddress?: string) {


initialize with props? : {address?:string, ...

arhtudormorar · 2024-12-16T11:39:41Z

src/utils/modalEvent.ts

+  withEventBus?: boolean;
+};
+
+export const createModalElement = async <


rename file to createModalElement

arhtudormorar · 2024-12-16T11:49:46Z

src/core/providers-strategy/CrossWindowProviderStrategy.ts

+  private _signMessage: ((messageToSign: Message) => Promise<Message>) | null =
+    null;
+
+  constructor({ address = '', walletAddress }: CrossWindowProviderProps) {


props: CrossWindowProviderProps = ...
otherwise you have to do constructor({}}

src/core/providers-strategy/WalletConnectProviderStrategy.ts

mgavrila added 2 commits December 11, 2024 17:06

Add provider strategy

a54dfc7

Fix typo

6d93f6d

arhtudormorar reviewed Dec 11, 2024

View reviewed changes

mgavrila added 4 commits December 11, 2024 18:42

Update providers

aab270d

Update to string

51fb9a6

Fix sign message

d10b85f

Remove any type

64c86cd

arhtudormorar reviewed Dec 12, 2024

View reviewed changes

mgavrila added 3 commits December 12, 2024 12:28

Update providers

9832acc

Add address

a2e3ee4

Update func naming

35de508

arhtudormorar reviewed Dec 12, 2024

View reviewed changes

mgavrila added 10 commits December 12, 2024 18:26

Update providers

ff73286

Update custom provider constructor

296030a

Fix walletConnect persistance

070d6bf

Merge remote-tracking branch 'origin/development' into amg_provider_s…

cd32bcc

…trategy

Update walletConnect configuration

9ab44e7

Add address for extension provider

90e0f33

Add getEventBus func

3e16b3b

Remove type from customProvider

36c1057

Update ledger provider

d4cbbb0

Add missing jest env

000f95d

arhtudormorar reviewed Dec 16, 2024

View reviewed changes

mgavrila added 2 commits December 16, 2024 13:16

Improve providers

90fcade

Update initialize func

a6eb671

arhtudormorar reviewed Dec 16, 2024

View reviewed changes

Add configs inside providers object

230f478

arhtudormorar reviewed Dec 16, 2024

View reviewed changes

Fix default param for crosswindow

3b1e506

arhtudormorar approved these changes Dec 16, 2024

View reviewed changes

mgavrila merged commit 8a312d4 into development Dec 16, 2024
1 check failed

mgavrila deleted the amg_provider_strategy branch December 16, 2024 11:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add provider strategy #46

Add provider strategy #46

mgavrila commented Dec 11, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

arhtudormorar Dec 16, 2024

Add provider strategy #46

Add provider strategy #46

Conversation

mgavrila commented Dec 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment