very small refactoring

multiversx · Jul 4, 2024 · 2a46daf · 2a46daf
1 parent 969d0df
commit 2a46daf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/transactionsFactories/smartContractTransactionsFactory.ts b/src/transactionsFactories/smartContractTransactionsFactory.ts
@@ -96,9 +96,7 @@ export class SmartContractTransactionsFactory {
         let numberOfTokens = tokenTransfers.length;
 
         if (nativeTransferAmount && numberOfTokens) {
-            const nativeTransfer = TokenTransfer.newFromEgldAmount(nativeTransferAmount);
-            tokenTransfers.push(nativeTransfer);
-
+            tokenTransfers.push(TokenTransfer.newFromEgldAmount(nativeTransferAmount));
             nativeTransferAmount = 0n;
             numberOfTokens++;
         }

diff --git a/src/transactionsFactories/transferTransactionsFactory.ts b/src/transactionsFactories/transferTransactionsFactory.ts
@@ -155,15 +155,15 @@ export class TransferTransactionsFactory {
         let tokenTransfers = options.tokenTransfers ? [...options.tokenTransfers] : [];
         const numberOfTokens = tokenTransfers.length;
 
-        if (!nativeAmount && !numberOfTokens) {
+        if (!nativeAmount && numberOfTokens === 0) {
             throw new ErrBadUsage("No native token amount or token transfers provided");
         }
 
         if (numberOfTokens && options.data?.length) {
             throw new ErrBadUsage("Can't set data field when sending esdt tokens");
         }
 
-        if (nativeAmount && !tokenTransfers) {
+        if (nativeAmount && numberOfTokens === 0) {
             return this.createTransactionForNativeTokenTransfer({
                 sender: options.sender,
                 receiver: options.receiver,
@@ -173,7 +173,9 @@ export class TransferTransactionsFactory {
         }
 
         const nativeTransfer = nativeAmount ? TokenTransfer.newFromEgldAmount(nativeAmount) : undefined;
-        nativeTransfer ? tokenTransfers.push(nativeTransfer) : null;
+        if (nativeTransfer) {
+            tokenTransfers.push(nativeTransfer);
+        }
 
         return this.createTransactionForESDTTokenTransfer({
             sender: options.sender,