Skip to content

Commit

Permalink
Breaking (but small) change: remove some previously deprecated items.
Browse files Browse the repository at this point in the history
  • Loading branch information
andreibancioiu committed Nov 15, 2023
1 parent 91d1d43 commit ad8b733
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 54 deletions.
10 changes: 0 additions & 10 deletions src/interfaceOfNetwork.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,16 +66,6 @@ export interface ITransactionLogs {
events: ITransactionEvent[];

findSingleOrNoneEvent(identifier: string, predicate?: (event: ITransactionEvent) => boolean): ITransactionEvent | undefined;

/**
* @deprecated Will be removed from the interface (with no replacement). Not used in "sdk-core".
*/
findFirstOrNoneEvent(identifier: string, predicate?: (event: ITransactionEvent) => boolean): ITransactionEvent | undefined;

/**
* @deprecated Will be removed from the interface (with no replacement). Not used in "sdk-core".
*/
findEvents(identifier: string, predicate?: (event: ITransactionEvent) => boolean): ITransactionEvent[];
}

export interface ITransactionEvent {
Expand Down
24 changes: 4 additions & 20 deletions src/smartcontracts/interaction.ts
Original file line number Diff line number Diff line change
Expand Up @@ -150,34 +150,18 @@ export class Interaction {
}

withSingleESDTNFTTransfer(transfer: ITokenTransfer): Interaction;
/**
* @deprecated do not pass the "sender" parameter. Make sure to call "withSender()", instead.
*/
withSingleESDTNFTTransfer(transfer: ITokenTransfer, sender?: IAddress): Interaction;
withSingleESDTNFTTransfer(transfer: ITokenTransfer, sender?: IAddress): Interaction {

withSingleESDTNFTTransfer(transfer: ITokenTransfer): Interaction {
this.isWithSingleESDTNFTTransfer = true;
this.tokenTransfers = new TokenTransfersWithinInteraction([transfer], this);

if (sender) {
this.sender = sender;
}

return this;
}

withMultiESDTNFTTransfer(transfers: ITokenTransfer[]): Interaction;
/**
* @deprecated do not pass the "sender" parameter. Make sure to call "withSender()", instead.
*/
withMultiESDTNFTTransfer(transfers: ITokenTransfer[], sender?: IAddress): Interaction;
withMultiESDTNFTTransfer(transfers: ITokenTransfer[], sender?: IAddress): Interaction {

withMultiESDTNFTTransfer(transfers: ITokenTransfer[]): Interaction {
this.isWithMultiESDTNFTTransfer = true;
this.tokenTransfers = new TokenTransfersWithinInteraction(transfers, this);

if (sender) {
this.sender = sender;
}

return this;
}

Expand Down
4 changes: 0 additions & 4 deletions src/smartcontracts/transactionPayloadBuilders.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@ import { ArgSerializer } from "./argSerializer";
import { ICode, ICodeMetadata, IContractFunction } from "./interface";
import { TypedValue } from "./typesystem";

/**
* @deprecated This constant should not be used. Use {@link WasmVirtualMachine} instead.
*/
export const ArwenVirtualMachine = "0500";
export const WasmVirtualMachine = "0500";

/**
Expand Down
10 changes: 0 additions & 10 deletions src/tokenOperations/tokenOperationsFactory.test.net.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,6 @@ describe("test factory on testnet", function () {
canFreeze: true,
canWipe: true,
canPause: true,
canMint: true,
canBurn: true,
canChangeOwner: true,
canUpgrade: true,
canAddSpecialRoles: true,
Expand Down Expand Up @@ -184,8 +182,6 @@ describe("test factory on testnet", function () {
canFreeze: true,
canWipe: true,
canPause: true,
canMint: true,
canBurn: true,
canChangeOwner: true,
canUpgrade: true,
canAddSpecialRoles: true,
Expand Down Expand Up @@ -253,8 +249,6 @@ describe("test factory on testnet", function () {
canFreeze: true,
canWipe: true,
canPause: true,
canMint: true,
canBurn: true,
canChangeOwner: true,
canUpgrade: true,
canAddSpecialRoles: true,
Expand Down Expand Up @@ -312,8 +306,6 @@ describe("test factory on testnet", function () {
canFreeze: true,
canWipe: true,
canPause: true,
canMint: true,
canBurn: true,
canChangeOwner: true,
canUpgrade: true,
canAddSpecialRoles: true,
Expand Down Expand Up @@ -381,8 +373,6 @@ describe("test factory on testnet", function () {
canFreeze: true,
canWipe: true,
canPause: true,
canMint: true,
canBurn: true,
canChangeOwner: true,
canUpgrade: true,
canAddSpecialRoles: true,
Expand Down
10 changes: 0 additions & 10 deletions src/tokenOperations/tokenOperationsFactory.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,16 +48,6 @@ interface IIssueFungibleArgs extends IBaseArgs {
canChangeOwner: boolean;
canUpgrade: boolean;
canAddSpecialRoles: boolean;

/**
* @deprecated (not used anymore)
*/
canMint?: boolean;

/**
* @deprecated (not used anymore)
*/
canBurn?: boolean;
}

interface IIssueSemiFungibleArgs extends IBaseArgs {
Expand Down

0 comments on commit ad8b733

Please sign in to comment.