Fix type expression parser #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccorcoveanu
requested changes
Aug 1, 2022
There was a problem hiding this comment.
Hi @nvergez and thanks for the contribution!
Can you please run an npm install and also commit package-lock?
ccorcoveanu
approved these changes
Aug 1, 2022
andreibancioiu
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I got an error when I tried to import and parse an abi with the type
tuple<List<u64>,List<u64>>. I saw the commented test insrc/smartcontracts/typesystem/typeExpressionParser.spec.tswhich is basically the same case as mine.I just fixed the problem adding a condition in the function
getJsonedString. I uncommented the commented test and added my specific case in the test file because it tests the '>before,' case and the 'JSON key de-duplication' case.