Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix construction of AbiRegistry #234

Merged
merged 4 commits into from
Sep 20, 2022
Merged

Fix construction of AbiRegistry #234

merged 4 commits into from
Sep 20, 2022

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented Sep 19, 2022

Theoretically, this fix is not a breaking change - since, usually, the AbiRegistry is normally created from an untyped JSON:

https://docs.elrond.com/sdk-and-tools/erdjs/erdjs-cookbook/#abi

@andreibancioiu andreibancioiu self-assigned this Sep 19, 2022
@andreibancioiu andreibancioiu changed the title Fix construction of abi registry Fix construction of AbiRegistry Sep 19, 2022
danielailie
danielailie previously approved these changes Sep 19, 2022
## 11.0.0
- [Breaking change: Sender is now mandatory when constructing a transaction](https://github.com/ElrondNetwork/elrond-sdk-erdjs/pull/TBD)
- [Breaking change: Sender is now mandatory when constructing a transaction](https://github.com/ElrondNetwork/elrond-sdk-erdjs/pull/226)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you :)

@andreibancioiu andreibancioiu merged commit 59d8048 into main Sep 20, 2022
@andreibancioiu andreibancioiu deleted the fix-abi-registry branch September 20, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants