Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround: fix import of "proto" #295

Merged
merged 1 commit into from
May 12, 2023
Merged

Workaround: fix import of "proto" #295

merged 1 commit into from
May 12, 2023

Conversation

andreibancioiu
Copy link
Contributor

@andreibancioiu andreibancioiu commented May 12, 2023 •
edited
Loading

Avoid namespace pollution - compiled.js seems to do bad namespace management, which results into conflicting serialization logic among different versions of sdk-core.

@andreibancioiu andreibancioiu self-assigned this May 12, 2023
@andreibancioiu andreibancioiu marked this pull request as ready for review May 12, 2023 09:21
@andreibancioiu andreibancioiu merged commit 315bde0 into main May 12, 2023
@andreibancioiu andreibancioiu deleted the proto-import branch May 12, 2023 09:25
@andreibancioiu andreibancioiu mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanghel tanghel tanghel approved these changes

@bogdan-rosianu bogdan-rosianu bogdan-rosianu approved these changes

Assignees

@andreibancioiu andreibancioiu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreibancioiu @tanghel @bogdan-rosianu