Remove old wallet package from dev-dependencies #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/testutils/wallets.ts
Outdated
| @@ -73,7 +72,7 @@ export class TestWallet { | |||
| readonly secretKeyHex: string; | |||
| readonly secretKey: Buffer; | |||
| readonly signer: UserSigner; | |||
| readonly signerNext: UserSignerNext; | |||
| readonly signerNext: UserSigner; | |||
There was a problem hiding this comment.
I think can be dropped now.
src/testutils/wallets.ts
Outdated
| @@ -83,7 +82,7 @@ export class TestWallet { | |||
| this.secretKeyHex = secretKeyHex; | |||
| this.secretKey = Buffer.from(secretKeyHex, "hex"); | |||
| this.signer = new UserSigner(UserSecretKey.fromString(secretKeyHex)); | |||
| this.signerNext = new UserSignerNext(UserSecretKey.fromString(secretKeyHex)); | |||
| this.signerNext = new UserSigner(UserSecretKey.fromString(secretKeyHex)); | |||
There was a problem hiding this comment.
Now, a duplicate of the above.
andreibancioiu
approved these changes
Dec 18, 2023
MiroMargineanu
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed old wallet package (v3.0.0) and replaced
sdk-wallet-next(v4.0.0)tosdk-wallet(v4.2.0).