Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Default Transaction Version=2 and fix failing unit tests #365

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Set Default Transaction Version=2 and fix failing unit tests #365

merged 2 commits into from
Dec 22, 2023

Conversation

popenta
Copy link
Contributor

@popenta popenta commented Dec 19, 2023

No description provided.

@popenta popenta self-assigned this Dec 19, 2023
@popenta popenta marked this pull request as draft December 19, 2023 10:19
Base automatically changed from remove-old-wallet to feat/next December 19, 2023 11:56
@popenta popenta marked this pull request as ready for review December 19, 2023 11:56
andreibancioiu
andreibancioiu approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@andreibancioiu andreibancioiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎄

But we should also handle this in v13:
#367

@popenta
Copy link
Contributor Author

popenta commented Dec 22, 2023

Will do this in the PR that implements the relayed transactions factory.

🎄

But we should also handle this in v13: #367

@popenta popenta merged commit 8f82766 into feat/next Dec 22, 2023
1 check passed
@popenta popenta deleted the set-tx-version-2 branch December 22, 2023 14:22
@popenta popenta mentioned this pull request Jan 4, 2024
Closed
@popenta popenta mentioned this pull request Feb 13, 2024
Merged
@andreibancioiu andreibancioiu mentioned this pull request Mar 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreibancioiu andreibancioiu andreibancioiu approved these changes

@CiprianDraghici CiprianDraghici CiprianDraghici approved these changes

Assignees

@popenta popenta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@popenta @andreibancioiu @CiprianDraghici