Add address validator static method without throwing errors #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
approved these changes
Jan 6, 2024
There was a problem hiding this comment.
Thanks for the contribution 🙏
In the future, this will change a bit, since we'll support addresses with other HRPs, as well.
A general-purpose address validation facility would be added somewhere here - perhaps within the AddressComputer:
https://github.com/multiversx/mx-sdk-specs/blob/main/sdk-core/address.md
Additional notes:
popenta
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having it as a static method on Address would be super helpful. In many cases, it is good to have a validation without the need to try-catch; at least, I found it helpful. But please remove it if it isn't suitable here or if it should be coded differently. The main goal is to have validation for the address (string) without the need for try-catch.