Address wrt. specs (partially). Additional minor breaking changes. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ers anymore. Replacement: Address.empty().
…ed to be empty (or zero), an error is thrown (instead of just displaying a WARN).
andreibancioiu
changed the title
andreibancioiu
changed the title
popenta
approved these changes
Feb 16, 2024
radumojic
approved these changes
Feb 16, 2024
This was referenced Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address, wrt. specs: https://github.com/multiversx/mx-sdk-specs/blob/main/sdk-core/address.mdAddressconstructor cannot be called without parameters anymore. Replacement:Address.empty(). However, generally speaking,new Address(/no params/)should have never been used within client code. Just the same,Address.empty()should not be used by client code (internal use only).interaction.buildTransaction()will throw ifwithSender()wasn't called. The WARN was on ~1 year.