Align Address with sdk-specs, as much as possible (without breaking changes) #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreibancioiu
commented
May 15, 2024
| @@ -8,6 +8,7 @@ import { TransactionBuilder } from "./transactionBuilder"; | |||
|
|
|||
| interface IConfig { | |||
| chainID: string; | |||
| addressHrp: string; | |||
There was a problem hiding this comment.
Negligible breaking change.
andreibancioiu
commented
May 15, 2024
| @@ -13,6 +13,7 @@ import { TransactionBuilder } from "./transactionBuilder"; | |||
|
|
|||
| interface IConfig { | |||
| chainID: string; | |||
| addressHrp: string; | |||
There was a problem hiding this comment.
Negligible breaking change.
andreibancioiu
commented
May 15, 2024
| @@ -8,6 +8,7 @@ import { TransactionBuilder } from "./transactionBuilder"; | |||
|
|
|||
| interface IConfig { | |||
| chainID: string; | |||
| addressHrp: string; | |||
There was a problem hiding this comment.
Negligible breaking change.
popenta
reviewed
May 15, 2024
| @@ -140,7 +165,7 @@ export class Address { | |||
| const prefix = decoded?.prefix; | |||
| const pubkey = decoded ? Buffer.from(bech32.fromWords(decoded.words)) : undefined; | |||
|
|
|||
| if (prefix !== HRP || pubkey?.length !== PUBKEY_LENGTH) { | |||
| if (prefix !== LibraryConfig.DefaultAddressHrp || pubkey?.length !== PUBKEY_LENGTH) { | |||
There was a problem hiding this comment.
why is the address considered not valid if the hrp is different than the default?
There was a problem hiding this comment.
Good question!
In order to avoid a breaking change with respect to the behavior of isValid (public method). We will change this in the future (a major version).
| @@ -83,7 +86,7 @@ export class TokenManagementTransactionsFactory { | |||
| return new TransactionBuilder({ | |||
| config: this.config, | |||
| sender: options.sender, | |||
| receiver: Address.fromBech32(ESDT_CONTRACT_ADDRESS), | |||
| receiver: Address.fromHex(ESDT_CONTRACT_ADDRESS_HEX, this.config.addressHrp), | |||
There was a problem hiding this comment.
use this.esdtContractAddress
popenta
previously approved these changes
May 27, 2024
danielailie
previously approved these changes
May 27, 2024
danielailie
approved these changes
May 27, 2024
popenta
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresswith the specs, as much as possible (but avoid breaking changes): https://github.com/multiversx/mx-sdk-specs/blob/main/core/address.md.ensureValidTransactionFields, drop the logic that checks address length