New transaction status for proxy #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiprianDraghici
approved these changes
Jul 12, 2023
andreibancioiu
approved these changes
Jul 12, 2023
|
Related to: multiversx/mx-chain-proxy-go#386. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now for the proxy provider in order to get the transaction status we use the
/process-statusroute.The
TransactionOnNetwork.isCompletedfield is now optional and that could impact some people who were dependent on that field. IfisCompletedis needed callgetTransaction("txHash", withProcessStatus=True).The
isCompletedfield is set only whengetTransaction()was called usingwithProcessStatus = True.When calling
getTransaction()for the proxy provider an optional parameter calledwithProcessStatus: boolcan also be provided. IfwithProcessStatusis set toTruethe/process-statusroute is also called. The transaction's status is then replaced with theprocess_status.