-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool 233 extend user agent on js network providers #67
Changes from all commits
9a91315
b014180
691a1a9
e6a6609
8089c7e
fc2503a
9f9e675
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { AxiosRequestConfig } from 'axios'; | ||
|
||
export interface NetworkProviderConfig extends AxiosRequestConfig { | ||
clientName?: string; | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import { AxiosHeaders } from "axios"; | ||
import { NetworkProviderConfig } from "./networkProviderConfig"; | ||
import { UnknownClientName } from "./constants"; | ||
|
||
export function extendUserAgent(userAgentPrefix: string, config: NetworkProviderConfig) { | ||
if (!config.headers) { | ||
config.headers = new AxiosHeaders({}) | ||
}; | ||
if (!config.clientName) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check can be above There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
console.log("Can you please provide the client name of the application that uses the SDK? It will be used for metrics.") | ||
} | ||
const headers = AxiosHeaders.from(config.headers as AxiosHeaders).normalize(true); | ||
const resolvedClientName = config.clientName || UnknownClientName; | ||
|
||
const currentUserAgent = headers.hasUserAgent() ? headers.getUserAgent() : ''; | ||
const newUserAgent = currentUserAgent ? `${currentUserAgent} ${userAgentPrefix}/${resolvedClientName}` : `${userAgentPrefix}/${resolvedClientName}`; | ||
|
||
headers.setUserAgent(newUserAgent, true); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍