getting smart contract results from logs #1163
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Sometimes, for a reason I ignore, the smartContractResults field is not present in the proxy's /transactions/:txHash?withResults=true endpoint, despite the transaction actually have results. In this case we can get them from logs.
In order to handle this I changed the way you parse the response.
Just a word the
issue_non_fungible_new_token_identifier
function. The previous signature wasResult<String, TxResponseStatus>
, but the function either finish withOk(...)
or never finish (panic via the macro or via forced unwrapping). I might miss something here.I would have changed the signature to
Option<String>
(and so removing theResult<...>
), but I saw in themultisig_interact_nfts.rs
andinteractor_sc_call.rs
files that you are printing the error, so I think you plan to implement it later? So finally I left theResult
as is and the output isResult<Option<String>, TxResponseStatus>