Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create expect error #1558

Merged
merged 2 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,7 @@ fn tx_expect_error_test() {
.to(SC_PMF)
.typed(pmf_proxy::PanicMessageFeaturesProxy)
.sc_panic()
.with_result(ExpectStatus(4))
.with_result(ExpectMessage("sc_panic! test"))
.with_result(ExpectError("sc_panic! test", 4))
.run();
}

Expand All @@ -87,7 +86,6 @@ fn query_expect_error_test() {
.to(SC_PMF)
.typed(pmf_proxy::PanicMessageFeaturesProxy)
.sc_panic()
.with_result(ExpectStatus(4))
.with_result(ExpectMessage("sc_panic! test"))
.with_result(ExpectError("sc_panic! test", 4))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a testing-test, let's have all 3.

.run();
}
6 changes: 2 additions & 4 deletions framework/scenario/src/facade/result_handlers.rs
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
mod expect_message;
mod expect_status;
mod expect_error;
mod returns_message;
mod returns_new_bech32_address;
mod returns_new_token_identifier;
mod returns_status;
mod with_tx_raw_response;

pub use expect_message::ExpectMessage;
pub use expect_status::ExpectStatus;
pub use expect_error::ExpectError;
pub use returns_message::ReturnsMessage;
pub use returns_new_bech32_address::ReturnsNewBech32Address;
pub use returns_new_token_identifier::ReturnsNewTokenIdentifier;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,19 @@ use multiversx_sc::types::{RHListItem, RHListItemExec, TxEnv};

use crate::scenario_model::{BytesValue, CheckValue, TxExpect, TxResponse};

/// Verifies that transaction result message matches the given one.
/// Verifies that transaction result error matches the given one.
///
/// Can only be used in tests and interactors, not available in contracts.
pub struct ExpectMessage<'a>(pub &'a str);
pub struct ExpectError<'a>(pub &'a str, pub u64);
BiancaIalangi marked this conversation as resolved.
Show resolved Hide resolved

impl<'a, Env, Original> RHListItem<Env, Original> for ExpectMessage<'a>
impl<'a, Env, Original> RHListItem<Env, Original> for ExpectError<'a>
where
Env: TxEnv,
{
type Returns = ();
}

impl<'a, Env, Original> RHListItemExec<TxResponse, Env, Original> for ExpectMessage<'a>
impl<'a, Env, Original> RHListItemExec<TxResponse, Env, Original> for ExpectError<'a>
where
Env: TxEnv<RHExpect = TxExpect>,
{
Expand All @@ -25,6 +25,7 @@ where
original: ValueSubTree::Str(format!("str:{}", self.0)),
};
prev.message = CheckValue::Equal(expect_message_expr);
prev.status = CheckValue::Equal(self.1.into());
prev
}

Expand Down
27 changes: 0 additions & 27 deletions framework/scenario/src/facade/result_handlers/expect_status.rs

This file was deleted.

Loading