Added reset function on the StaticApi #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-marinica
approved these changes
Apr 30, 2024
BiancaIalangi
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
In the current implementation, StaticApi doesn't clean its data. It leads to severe memory leaks and therefore it makes the sdk unusable for long running processes such as backend APIs. I started a PR 2 weeks ago to experiment some stuff: #1545. However, more work is needed to ensure it won't introduce negative side effects. Anyway, in the meantime we need a way to avoid memory leaks, this is what this PR is about.
Implementation
Since we need a workaround for this issue, this PR adds a function called
reseton the StaticApi which resets all the data. After calling this function, StaticApi acts it has never been used, and the old datas held are automatically dropped.This is a good manual workaround before implementing an automatic data cleaning solution, any backend framework based on the StaticApi can call the
resetfunction behind the scene so developers won't even notice it.