Erdjs interaction examples #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alyn509
reviewed
Jun 30, 2021
Comment on lines
+37
to
+41
| // Wait a minute first, otherwise you'll get the "cannot claim before deadline" error | ||
| // If the claim doesn't return an error - there are two possibilities: | ||
| // - the funding failed, and 1.5 EGLD are sent back to both bob and carol | ||
| // - it was succesful and alice receives 3 EGLD | ||
| // Because the target sum specified on deployment was 2 EGLD, and we have 3 EGLD, the funding should be succesful |
There was a problem hiding this comment.
I think you should make a separate section in the docs where you write these stuff..
There was a problem hiding this comment.
This info depends on the following example
alyn509
reviewed
Jun 30, 2021
Comment on lines
+45
to
+49
| // Wait a minute first, otherwise you'll get the "cannot claim before deadline" error | ||
| // If the claim doesn't return an error - there are two possibilities: | ||
| // - the funding failed, and 1.5 MYTOKEN are sent back to both bob and carol | ||
| // - it was succesful and alice receives 3 MYTOKEN | ||
| // Because the target sum specified on deployment was 2 MYTOKEN, and we have 3 MYTOKEN, the funding should be succesful |
alyn509
reviewed
Jun 30, 2021
Comment on lines
11
to
12
| // Deploy a multisig contract with a quorum of 3, but 4 possible signers: alice, bob, carol, dan | ||
| // A quorum is the minimum required number of signers in order to be able to perform a proposed action |
There was a problem hiding this comment.
new notion => write it in the docs
There was a problem hiding this comment.
This info is already in the readme for this contract. I left a note at the top of this script pointing to that readme.
alyn509
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added interaction examples for several example smart contracts, as well as for basic ESDT scenarios.
The
erdjscontract wrapper implementation which enables these examples can be found in: multiversx/mx-sdk-js-core#9