Skip to content

Syn library update #468

Syn library update

Syn library update #468

GitHub Actions / clippy failed Nov 28, 2023 in 0s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (8)

framework/derive/src/lib.rs|30 col 30| warning: redundant clone
--> framework/derive/src/lib.rs:30:30
|
30 | println!(" args {}", args.clone());
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> framework/derive/src/lib.rs:30:26
|
30 | println!(" args {}", args.clone());
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
framework/derive/src/lib.rs|31 col 32| warning: redundant clone
--> framework/derive/src/lib.rs:31:32
|
31 | println!(" input {}", input.clone());
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> framework/derive/src/lib.rs:31:27
|
31 | println!(" input {}", input.clone());
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
framework/derive/src/lib.rs|30 col 30| warning: redundant clone
--> framework/derive/src/lib.rs:30:30
|
30 | println!(" args {}", args.clone());
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> framework/derive/src/lib.rs:30:26
|
30 | println!(" args {}", args.clone());
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
framework/derive/src/lib.rs|31 col 32| warning: redundant clone
--> framework/derive/src/lib.rs:31:32
|
31 | println!(" input {}", input.clone());
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> framework/derive/src/lib.rs:31:27
|
31 | println!(" input {}", input.clone());
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
framework/derive/src/lib.rs|30 col 30| warning: redundant clone
--> framework/derive/src/lib.rs:30:30
|
30 | println!(" args {}", args.clone());
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> framework/derive/src/lib.rs:30:26
|
30 | println!(" args {}", args.clone());
| ^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
= note: #[warn(clippy::redundant_clone)] on by default
framework/derive/src/lib.rs|31 col 32| warning: redundant clone
--> framework/derive/src/lib.rs:31:32
|
31 | println!(" input {}", input.clone());
| ^^^^^^^^ help: remove this
|
note: cloned value is neither consumed nor mutated
--> framework/derive/src/lib.rs:31:27
|
31 | println!(" input {}", input.clone());
| ^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs|40 col 13| warning: calls to push immediately after creation
--> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13
|
40 | / let mut inner_vec =
41 | | crate::types::heap::Vec::<multiversx_sc::abi::StructFieldDescription>::new();
42 | | inner_vec.push(inner_biguint);
| |^ help: consider using the vec![] macro: let inner_vec = vec![..];
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: #[warn(clippy::vec_init_then_push)] on by default
framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs|40 col 13| warning: calls to push immediately after creation
--> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13
|
40 | / let mut inner_vec =
41 | | crate::types::heap::Vec::<multiversx_sc::abi::StructFieldDescription>::new();
42 | | inner_vec.push(inner_biguint);
| |
^ help: consider using the vec![] macro: let inner_vec = vec![..];
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
= note: #[warn(clippy::vec_init_then_push)] on by default

Filtered Findings (22)

framework/derive/src/macro_contract.rs|7 col 5| warning: unused variable: args
--> framework/derive/src/macro_contract.rs:7:5
|
7 | args: proc_macro::TokenStream,
| ^^^^ help: if this is intentional, prefix it with an underscore: _args
|
= note: #[warn(unused_variables)] on by default
framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs|13 col 5| warning: unused import: crate::derive::TypeAbi
--> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:13:5
|
13 | use crate::derive::TypeAbi;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
framework/derive/src/macro_contract.rs|7 col 5| warning: unused variable: args
--> framework/derive/src/macro_contract.rs:7:5
|
7 | args: proc_macro::TokenStream,
| ^^^^ help: if this is intentional, prefix it with an underscore: _args
|
= note: #[warn(unused_variables)] on by default
framework/derive/src/macro_contract.rs|7 col 5| warning: unused variable: args
--> framework/derive/src/macro_contract.rs:7:5
|
7 | args: proc_macro::TokenStream,
| ^^^^ help: if this is intentional, prefix it with an underscore: _args
|
= note: #[warn(unused_variables)] on by default
framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs|13 col 5| warning: unused import: crate::derive::TypeAbi
--> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:13:5
|
13 | use crate::derive::TypeAbi;
| ^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
contracts/modules/src/token_merge/custom_merged_token_attributes.rs|9 col 57| error[E0405]: cannot find trait MergedTokenSetupModule in module super::merged_token_setup
--> contracts/modules/src/token_merge/custom_merged_token_attributes.rs:9:57
|
9 | pub trait AllMergeScTraits = super::merged_token_setup::MergedTokenSetupModule
| ^^^^^^^^^^^^^^^^^^^^^^ not found in super::merged_token_setup
contracts/modules/src/token_merge/custom_merged_token_attributes.rs|10 col 39| error[E0405]: cannot find trait DefaultIssueCallbacksModule in module crate::default_issue_callbacks
--> contracts/modules/src/token_merge/custom_merged_token_attributes.rs:10:39
|
10 | + crate::default_issue_callbacks::DefaultIssueCallbacksModule
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in crate::default_issue_callbacks
contracts/modules/src/token_merge/custom_merged_token_attributes.rs|11 col 21| error[E0405]: cannot find trait PauseModule in module crate::pause
--> contracts/modules/src/token_merge/custom_merged_token_attributes.rs:11:21
|
11 | + crate::pause::PauseModule;
| ^^^^^^^^^^^ not found in crate::pause
contracts/modules/src/bonding_curve/utils/owner_endpoints.rs|4 col 5| warning: unused import: multiversx_sc::contract_base::ManagedSerializer
--> contracts/modules/src/bonding_curve/utils/owner_endpoints.rs:4:5
|
4 | use multiversx_sc::contract_base::ManagedSerializer;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default
contracts/modules/src/bonding_curve/utils/owner_endpoints.rs|7 col 5| warning: unused imports: BondingCurve, TokenOwnershipData, curves::curve_function::CurveFunction, events, storage
--> contracts/modules/src/bonding_curve/utils/owner_endpoints.rs:7:5
|
7 | curves::curve_function::CurveFunction,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8 | utils::{
9 | events, storage,
| ^^^^^^ ^^^^^^^
10 | structs::{BondingCurve, TokenOwnershipData},
| ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^
contracts/modules/src/bonding_curve/utils/owner_endpoints.rs|14 col 5| warning: unused import: super::structs::CurveArguments
--> contracts/modules/src/bonding_curve/utils/owner_endpoints.rs:14:5
|
14 | use super::structs::CurveArguments;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/bonding_curve/utils/storage.rs|4 col 5| warning: unused import: super::structs::TokenOwnershipData
--> contracts/modules/src/bonding_curve/utils/storage.rs:4:5
|
4 | use super::structs::TokenOwnershipData;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/bonding_curve/utils/user_endpoints.rs|4 col 5| warning: unused import: multiversx_sc::contract_base::ManagedSerializer
--> contracts/modules/src/bonding_curve/utils/user_endpoints.rs:4:5
|
4 | use multiversx_sc::contract_base::ManagedSerializer;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/bonding_curve/utils/user_endpoints.rs|7 col 5| warning: unused imports: curves::curve_function::CurveFunction, events, storage, structs::BondingCurve
--> contracts/modules/src/bonding_curve/utils/user_endpoints.rs:7:5
|
7 | curves::curve_function::CurveFunction,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
8 | utils::{events, storage, structs::BondingCurve},
| ^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/bonding_curve/mod.rs|6 col 13| warning: unused imports: events, owner_endpoints, storage, user_endpoints
--> contracts/modules/src/bonding_curve/mod.rs:6:13
|
6 | use utils::{events, owner_endpoints, storage, user_endpoints};
| ^^^^^^ ^^^^^^^^^^^^^^^ ^^^^^^^ ^^^^^^^^^^^^^^
contracts/modules/src/default_issue_callbacks.rs|1 col 21| warning: unused imports: storage::StorageKey, storage_clear, storage_set
--> contracts/modules/src/default_issue_callbacks.rs:1:21
|
1 | use multiversx_sc::{storage::StorageKey, storage_clear, storage_set};
| ^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^^
contracts/modules/src/governance/governance_events.rs|3 col 5| warning: unused import: super::governance_proposal::GovernanceProposal
--> contracts/modules/src/governance/governance_events.rs:3:5
|
3 | use super::governance_proposal::GovernanceProposal;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/governance/governance_events.rs|4 col 5| warning: unused import: crate::governance::ProposalId
--> contracts/modules/src/governance/governance_events.rs:4:5
|
4 | use crate::governance::ProposalId;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/token_merge/merged_token_setup.rs|4 col 5| warning: unused imports: MAX_MERGED_TOKENS, MergedTokenInstances, custom_merged_token_attributes::MergedTokenAttributesCreator
--> contracts/modules/src/token_merge/merged_token_setup.rs:4:5
|
4 | custom_merged_token_attributes::MergedTokenAttributesCreator,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
5 | merged_token_instances::{MergedTokenInstances, MAX_MERGED_TOKENS},
| ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
contracts/modules/src/token_merge/mod.rs|8 col 30| warning: unused imports: MAX_MERGED_TOKENS, MergedTokenInstances
--> contracts/modules/src/token_merge/mod.rs:8:30
|
8 | use merged_token_instances::{MergedTokenInstances, MAX_MERGED_TOKENS};
| ^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^
contracts/modules/src/token_merge/mod.rs|10 col 5| warning: unused import: self::custom_merged_token_attributes::MergedTokenAttributesCreator
--> contracts/modules/src/token_merge/mod.rs:10:5
|
10 | use self::custom_merged_token_attributes::MergedTokenAttributesCreator;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contracts/modules/src/transfer_role_proxy.rs|1 col 5| warning: unused import: multiversx_sc::codec::TopEncodeMulti
--> contracts/modules/src/transfer_role_proxy.rs:1:5
|
1 | use multiversx_sc::codec::TopEncodeMulti;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Annotations

Check warning on line 30 in framework/derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/lib.rs#L30

warning: redundant clone
  --> framework/derive/src/lib.rs:30:30
   |
30 |     println!(" args {}", args.clone());
   |                              ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:30:26
   |
30 |     println!(" args {}", args.clone());
   |                          ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default
Raw output
framework/derive/src/lib.rs:30:30:w:warning: redundant clone
  --> framework/derive/src/lib.rs:30:30
   |
30 |     println!(" args {}", args.clone());
   |                              ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:30:26
   |
30 |     println!(" args {}", args.clone());
   |                          ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default


__END__

Check warning on line 31 in framework/derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/lib.rs#L31

warning: redundant clone
  --> framework/derive/src/lib.rs:31:32
   |
31 |     println!(" input {}", input.clone());
   |                                ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:31:27
   |
31 |     println!(" input {}", input.clone());
   |                           ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Raw output
framework/derive/src/lib.rs:31:32:w:warning: redundant clone
  --> framework/derive/src/lib.rs:31:32
   |
31 |     println!(" input {}", input.clone());
   |                                ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:31:27
   |
31 |     println!(" input {}", input.clone());
   |                           ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone


__END__

Check warning on line 30 in framework/derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/lib.rs#L30

warning: redundant clone
  --> framework/derive/src/lib.rs:30:30
   |
30 |     println!(" args {}", args.clone());
   |                              ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:30:26
   |
30 |     println!(" args {}", args.clone());
   |                          ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default
Raw output
framework/derive/src/lib.rs:30:30:w:warning: redundant clone
  --> framework/derive/src/lib.rs:30:30
   |
30 |     println!(" args {}", args.clone());
   |                              ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:30:26
   |
30 |     println!(" args {}", args.clone());
   |                          ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default


__END__

Check warning on line 31 in framework/derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/lib.rs#L31

warning: redundant clone
  --> framework/derive/src/lib.rs:31:32
   |
31 |     println!(" input {}", input.clone());
   |                                ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:31:27
   |
31 |     println!(" input {}", input.clone());
   |                           ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Raw output
framework/derive/src/lib.rs:31:32:w:warning: redundant clone
  --> framework/derive/src/lib.rs:31:32
   |
31 |     println!(" input {}", input.clone());
   |                                ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:31:27
   |
31 |     println!(" input {}", input.clone());
   |                           ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone


__END__

Check warning on line 30 in framework/derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/lib.rs#L30

warning: redundant clone
  --> framework/derive/src/lib.rs:30:30
   |
30 |     println!(" args {}", args.clone());
   |                              ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:30:26
   |
30 |     println!(" args {}", args.clone());
   |                          ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default
Raw output
framework/derive/src/lib.rs:30:30:w:warning: redundant clone
  --> framework/derive/src/lib.rs:30:30
   |
30 |     println!(" args {}", args.clone());
   |                              ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:30:26
   |
30 |     println!(" args {}", args.clone());
   |                          ^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
   = note: `#[warn(clippy::redundant_clone)]` on by default


__END__

Check warning on line 31 in framework/derive/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/derive/src/lib.rs#L31

warning: redundant clone
  --> framework/derive/src/lib.rs:31:32
   |
31 |     println!(" input {}", input.clone());
   |                                ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:31:27
   |
31 |     println!(" input {}", input.clone());
   |                           ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone
Raw output
framework/derive/src/lib.rs:31:32:w:warning: redundant clone
  --> framework/derive/src/lib.rs:31:32
   |
31 |     println!(" input {}", input.clone());
   |                                ^^^^^^^^ help: remove this
   |
note: cloned value is neither consumed nor mutated
  --> framework/derive/src/lib.rs:31:27
   |
31 |     println!(" input {}", input.clone());
   |                           ^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone


__END__

Check warning on line 40 in framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs#L40

warning: calls to `push` immediately after creation
  --> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13
   |
40 | /             let mut inner_vec =
41 | |                 crate::types::heap::Vec::<multiversx_sc::abi::StructFieldDescription>::new();
42 | |             inner_vec.push(inner_biguint);
   | |__________________________________________^ help: consider using the `vec![]` macro: `let inner_vec = vec![..];`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
   = note: `#[warn(clippy::vec_init_then_push)]` on by default
Raw output
framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13:w:warning: calls to `push` immediately after creation
  --> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13
   |
40 | /             let mut inner_vec =
41 | |                 crate::types::heap::Vec::<multiversx_sc::abi::StructFieldDescription>::new();
42 | |             inner_vec.push(inner_biguint);
   | |__________________________________________^ help: consider using the `vec![]` macro: `let inner_vec = vec![..];`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
   = note: `#[warn(clippy::vec_init_then_push)]` on by default


__END__

Check warning on line 40 in framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs#L40

warning: calls to `push` immediately after creation
  --> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13
   |
40 | /             let mut inner_vec =
41 | |                 crate::types::heap::Vec::<multiversx_sc::abi::StructFieldDescription>::new();
42 | |             inner_vec.push(inner_biguint);
   | |__________________________________________^ help: consider using the `vec![]` macro: `let inner_vec = vec![..];`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
   = note: `#[warn(clippy::vec_init_then_push)]` on by default
Raw output
framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13:w:warning: calls to `push` immediately after creation
  --> framework/base/src/types/managed/wrapped/egld_or_multi_esdt_payment.rs:40:13
   |
40 | /             let mut inner_vec =
41 | |                 crate::types::heap::Vec::<multiversx_sc::abi::StructFieldDescription>::new();
42 | |             inner_vec.push(inner_biguint);
   | |__________________________________________^ help: consider using the `vec![]` macro: `let inner_vec = vec![..];`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push
   = note: `#[warn(clippy::vec_init_then_push)]` on by default


__END__