Skip to content

BigUint - ln

BigUint - ln #1884

GitHub Actions / clippy failed Jun 18, 2024 in 1s

reviewdog [clippy] report

reported by reviewdog 🐶

Findings (4)

tools/plotter/src/logarithm.rs|15 col 18| warning: useless use of format!
--> tools/plotter/src/logarithm.rs:15:18
|
15 | .caption(format!("y=ln(x)"), font)
| ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): "y=ln(x)".to_string()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: #[warn(clippy::useless_format)] on by default
tools/plotter/src/lib.rs|18 col 14| warning: very complex type used. Consider factoring parts into type definitions
--> tools/plotter/src/lib.rs:18:14
|
18 | convert: Box<dyn Fn((i32, i32)) -> Option<(f64, f64)>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: #[warn(clippy::type_complexity)] on by default
tools/plotter/src/logarithm.rs|15 col 18| warning: useless use of format!
--> tools/plotter/src/logarithm.rs:15:18
|
15 | .caption(format!("y=ln(x)"), font)
| ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): "y=ln(x)".to_string()
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
= note: #[warn(clippy::useless_format)] on by default
tools/plotter/src/lib.rs|18 col 14| warning: very complex type used. Consider factoring parts into type definitions
--> tools/plotter/src/lib.rs:18:14
|
18 | convert: Box<dyn Fn((i32, i32)) -> Option<(f64, f64)>>,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
= note: #[warn(clippy::type_complexity)] on by default

Filtered Findings (2)

framework/base/src/storage/mappers/vec_mapper.rs|15 col 33| warning: importing legacy numeric constants
--> framework/base/src/storage/mappers/vec_mapper.rs:15:33
|
15 | use core::{marker::PhantomData, usize};
| ^^^^^
|
= help: remove this import
= note: then usize::<CONST> will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: #[warn(clippy::legacy_numeric_constants)] on by default
framework/base/src/storage/mappers/vec_mapper.rs|15 col 33| warning: importing legacy numeric constants
--> framework/base/src/storage/mappers/vec_mapper.rs:15:33
|
15 | use core::{marker::PhantomData, usize};
| ^^^^^
|
= help: remove this import
= note: then usize::<CONST> will resolve to the respective associated constant
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: #[warn(clippy::legacy_numeric_constants)] on by default

Annotations

Check warning on line 15 in tools/plotter/src/logarithm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] tools/plotter/src/logarithm.rs#L15

warning: useless use of `format!`
  --> tools/plotter/src/logarithm.rs:15:18
   |
15 |         .caption(format!("y=ln(x)"), font)
   |                  ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"y=ln(x)".to_string()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
   = note: `#[warn(clippy::useless_format)]` on by default
Raw output
tools/plotter/src/logarithm.rs:15:18:w:warning: useless use of `format!`
  --> tools/plotter/src/logarithm.rs:15:18
   |
15 |         .caption(format!("y=ln(x)"), font)
   |                  ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"y=ln(x)".to_string()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
   = note: `#[warn(clippy::useless_format)]` on by default


__END__

Check warning on line 18 in tools/plotter/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] tools/plotter/src/lib.rs#L18

warning: very complex type used. Consider factoring parts into `type` definitions
  --> tools/plotter/src/lib.rs:18:14
   |
18 |     convert: Box<dyn Fn((i32, i32)) -> Option<(f64, f64)>>,
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default
Raw output
tools/plotter/src/lib.rs:18:14:w:warning: very complex type used. Consider factoring parts into `type` definitions
  --> tools/plotter/src/lib.rs:18:14
   |
18 |     convert: Box<dyn Fn((i32, i32)) -> Option<(f64, f64)>>,
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default


__END__

Check warning on line 15 in tools/plotter/src/logarithm.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] tools/plotter/src/logarithm.rs#L15

warning: useless use of `format!`
  --> tools/plotter/src/logarithm.rs:15:18
   |
15 |         .caption(format!("y=ln(x)"), font)
   |                  ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"y=ln(x)".to_string()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
   = note: `#[warn(clippy::useless_format)]` on by default
Raw output
tools/plotter/src/logarithm.rs:15:18:w:warning: useless use of `format!`
  --> tools/plotter/src/logarithm.rs:15:18
   |
15 |         .caption(format!("y=ln(x)"), font)
   |                  ^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"y=ln(x)".to_string()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
   = note: `#[warn(clippy::useless_format)]` on by default


__END__

Check warning on line 18 in tools/plotter/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

[clippy] tools/plotter/src/lib.rs#L18

warning: very complex type used. Consider factoring parts into `type` definitions
  --> tools/plotter/src/lib.rs:18:14
   |
18 |     convert: Box<dyn Fn((i32, i32)) -> Option<(f64, f64)>>,
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default
Raw output
tools/plotter/src/lib.rs:18:14:w:warning: very complex type used. Consider factoring parts into `type` definitions
  --> tools/plotter/src/lib.rs:18:14
   |
18 |     convert: Box<dyn Fn((i32, i32)) -> Option<(f64, f64)>>,
   |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default


__END__